Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check disconnected inputs in torch #1360

Merged
merged 1 commit into from
Feb 18, 2025
Merged

check disconnected inputs in torch #1360

merged 1 commit into from
Feb 18, 2025

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Feb 17, 2025

Pull Request Description:

Add explicit check that the model doesn't have disconnected inputs.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby marked this pull request as ready for review February 17, 2025 13:39
@irenaby irenaby requested a review from ofirgo February 17, 2025 13:39
@irenaby
Copy link
Collaborator Author

irenaby commented Feb 17, 2025

@ofirgo I don't see a way that output can be disconnected, so I only check inputs

@irenaby irenaby merged commit 3dfdbfe into main Feb 18, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants